Fix classloader memory leak, due to ClassTag#10500
Merged
mergify[bot] merged 4 commits intoplayframework:masterfrom Jan 25, 2021
Merged
Fix classloader memory leak, due to ClassTag#10500mergify[bot] merged 4 commits intoplayframework:masterfrom
mergify[bot] merged 4 commits intoplayframework:masterfrom
Conversation
dwijnand
reviewed
Oct 26, 2020
Member
|
@dwijnand Since you commented on this pull request a while ago and you are much more a Scala expert than I will ever be, can you please review this pull request once more? Thanks! |
Member
|
@dwijnand Thanks, I am going to merge and backport then. |
Member
|
@Mergifyio backport 2.8.x |
Contributor
|
Command
|
Member
|
@Mergifyio backport 2.7.x |
Contributor
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Jan 25, 2021
Fix classloader memory leak, due to ClassTag (bp #10500)
mergify bot
added a commit
that referenced
this pull request
Jan 26, 2021
Fix classloader memory leak, due to ClassTag (bp #10500)
jtjeferreira
added a commit
to jtjeferreira/playframework
that referenced
this pull request
Mar 24, 2021
jtjeferreira
added a commit
to jtjeferreira/playframework
that referenced
this pull request
Mar 24, 2021
raboof
added a commit
to raboof/playframework
that referenced
this pull request
Aug 3, 2021
This was reduced in playframework#10500, but perhaps a bit too tight for the dev-mode scripted test. Fixes playframework#10930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Fixes classloader memory leak, due to
ClassTagPurpose
Launches scripted tests with a limited metaspace size. With this change most of the tests fail. After analyzing the heap dump in yourkit profiler, one can see that
ClassTag#cacheis not allowing the classloaders created by play to be GCd.The fix is to separate the classloader that loads ClassTag from the classloaders that load the rest of the application classes (libraries and user code), and then the classloaders can be GCd.
I also opened a PR in scala (scala/scala#9276), but I also managed to fix it in play-plugin. As you can see in that PR discussion this is not a problem in scala 2.13, but the scripted tests only run with scala 2.12
References
#9935
scala/scala#9276