Fix #971 – "Exception occurred while executing macro expansion."#994
Merged
cchantep merged 1 commit intoplayframework:mainfrom Mar 5, 2024
Conversation
cchantep
reviewed
Mar 4, 2024
play-json/shared/src/main/scala-3/play/api/libs/json/JsMacroImpl.scala
Outdated
Show resolved
Hide resolved
9b3b4d7 to
ead441a
Compare
cchantep
approved these changes
Mar 5, 2024
Member
|
Should this be backported to 2.10.x and be part of a 2.10.5 release? |
Member
|
@Mergifyio backport 2.10.x |
Contributor
✅ Backports have been createdDetails
|
5 tasks
mkurz
added a commit
that referenced
this pull request
Apr 29, 2024
[2.10.x] Fix #971 – "Exception occurred while executing macro expansion." (backport #994) by @sgodbillon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes
Fixes #971 – "Exception occurred while executing macro expansion."
Purpose
What does this PR do?
Background Context
When the case class has generic parameters, generated methods for default parameters (
$lessinit$greater$default$XXX) have the same generic parameters – so it is necessary to provide the type parameters when calling them.References
Are there any relevant issues / PRs / mailing lists discussions?