StreamReadConstraints can use same digits limit like play-json internally uses#1254
Merged
mkurz merged 1 commit intoplayframework:mainfrom Nov 7, 2025
Merged
Conversation
Member
Author
|
@pjfanning Can you take a look because you added set the |
Contributor
|
The reason I set the max value is that the exception and message are different if Jackson throws it. I guess that this can be documented and that a minor release like 3.1.0 can allow for behaviour changes like this. |
mkurz
added a commit
to pjfanning/playframework
that referenced
this pull request
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can avoid
Int.MaxValuehere.In play-json itself we check the input's string length:
play-json/play-json/jvm/src/main/scala/play/api/libs/json/BigDecimalParser.scala
Lines 14 to 15 in 0d6505c
play-json/play-json/jvm/src/main/scala/play/api/libs/json/EnvReads.scala
Lines 729 to 731 in 0d6505c
In Jackson, it's basically doing the same:
Therefore we can just sync the limit and just use the one supplied by play-json.