Make format generation idempotent#1047
Merged
mkurz merged 1 commit intoplayframework:mainfrom Jun 17, 2024
Merged
Conversation
12ff8b8 to
27c2a35
Compare
mkurz
approved these changes
Jun 17, 2024
Member
mkurz
left a comment
There was a problem hiding this comment.
Seems legit.
Will be part of Play's next patch release.
Member
|
@Mergifyio backport 2.10.x |
Contributor
✅ Backports have been createdDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Code generated by JsMacroImpl is slightly different between compilations, the order of sealed trait's subclasses keeps changing, because they are collected into a Set in
directKnownSubclassesmethod. I've simply changed that to a LinkedHashSet.We're using bazel as a build tool and it's important for build to produce an exact same file for the same input, otherwise it's dependent targets are re-evaluated.
Purpose
Have better caching in bazel project using play framework.