Conversation
b6609b2 to
cfb4ae1
Compare
Member
Author
|
Hi, @mkurz! 👋 |
mkurz
reviewed
Jul 13, 2023
| # Disable caching of ~/.gradle/caches/build-cache-* | ||
| save-local-build-cache: false | ||
| # Disable caching of ~/.m2/repository/ | ||
| save-maven-dependencies-cache: false |
Member
There was a problem hiding this comment.
Just checking
save-generated-gradle-jars: falseandsave-gradle-dependencies-cache: false
are not needed? I guess you know what you are doing, just double checking :)
Member
Author
There was a problem hiding this comment.
Yes, I think the default values of these parameters are OK for us 😉
mkurz
approved these changes
Jul 13, 2023
Member
mkurz
left a comment
There was a problem hiding this comment.
I think this is OK. As long as all the previous, non-gradle things keep working, it should be OK.
mkurz
reviewed
Jul 13, 2023
|
|
||
| - name: Publish artifacts | ||
| run: sbt ci-release | ||
| run: ${{ inputs.cmd }} |
Member
There was a problem hiding this comment.
I like that, I think I already could have used that in the past.
Member
|
Feel free to merge / release when you a ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.