fix(scripts): remove inline {@link} from camera-frame LUT attribute description#8849
Merged
Conversation
…escription The CameraFrame script fails to parse in the Editor after the dual-LUT change (#8749). The texture2 attribute description contained an inline JSDoc {@link ColorLUT#blend} tag. When a JSDoc summary contains {@link}, TypeScript represents the comment as a NodeArray of comment nodes rather than a plain string. The attribute parser stores this verbatim as the attribute description, and because those nodes carry circular parent references, serializing the parsed schema throws 'Converting circular structure to JSON' - surfacing as an Editor parse error even though the program itself parses without error. Replace the inline link with plain prose so the description stays a string and the schema serializes cleanly.
mvaligursky
added a commit
that referenced
this pull request
Jun 5, 2026
…escription (#8849) The CameraFrame script fails to parse in the Editor after the dual-LUT change (#8749). The texture2 attribute description contained an inline JSDoc {@link ColorLUT#blend} tag. When a JSDoc summary contains {@link}, TypeScript represents the comment as a NodeArray of comment nodes rather than a plain string. The attribute parser stores this verbatim as the attribute description, and because those nodes carry circular parent references, serializing the parsed schema throws 'Converting circular structure to JSON' - surfacing as an Editor parse error even though the program itself parses without error. Replace the inline link with plain prose so the description stays a string and the schema serializes cleanly. Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CameraFrame script fails to parse in the Editor after the dual-LUT change (#8749). The
texture2attribute's description contained an inline JSDoc{@link ColorLUT#blend}tag.When a JSDoc summary contains
{@link}, TypeScript represents the comment as aNodeArrayof comment nodes rather than a plain string. The attribute parser stores this verbatim as the attribute'sdescription, and because those nodes carry circularparentreferences, serializing the parsed schema throwsConverting circular structure to JSON— surfacing as an Editor parse error even though the program itself parses without error.Changes:
{@link ColorLUT#blend}reference in thetexture2description with plain prose, so the description stays a string and the schema serializes cleanly.