Fix shaderParticle assignment (#7787)#7788
Merged
mvaligursky merged 1 commit intoplaycanvas:mainfrom Jun 19, 2025
Merged
Conversation
mvaligursky
approved these changes
Jun 19, 2025
Contributor
mvaligursky
left a comment
There was a problem hiding this comment.
Well spotted, thanks!
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the property used for the “stop” update shader in ParticleEmitter by renaming it to better reflect its purpose.
- Rename
shaderParticleUpdateNoRespawntoshaderParticleUpdateOnStopto match theON_STOPdefine.
Comments suppressed due to low confidence (1)
src/scene/particle-system/particle-emitter.js:695
- After renaming this property, update all references to
shaderParticleUpdateNoRespawnelsewhere in the class or consuming code toshaderParticleUpdateOnStopto prevent undefined property errors at runtime.
this.shaderParticleUpdateOnStop = ShaderUtils.createShader(gd, shaderOptions);
slimbuck
pushed a commit
that referenced
this pull request
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7787
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.