This repository was archived by the owner on Mar 29, 2025. It is now read-only.
Merged
Conversation
This was referenced Nov 2, 2020
flaub
reviewed
Nov 3, 2020
plaidml/op/op.h
Outdated
| public: | ||
| explicit repeat(const edsl::Tensor& I) : I_(I) {} | ||
|
|
||
| repeat& repeats(int repeats) { |
Contributor
There was a problem hiding this comment.
Maybe call this count to avoid confusion?
Contributor
Author
There was a problem hiding this comment.
Sure. The repeats matches numpy, but I agree that count is a less confusing name, so I made the switch.
flaub
approved these changes
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the API for repeat to enable the use of the new TensorDim repeats parameter, which I overlooked in #1518.