This repository was archived by the owner on Mar 29, 2025. It is now read-only.
Allow TensorDims to be used in Repeat#1518
Merged
mergify[bot] merged 1 commit intoplaidml-v1from Oct 31, 2020
Merged
Conversation
|
LGTM - seems like a reasonable way to avoid compute_shape/explicit broadcasting. For what it's worth, this wouldn't really have any impact on the TF frontend because XLA implements |
Contributor
|
FYI with the recent rewrite of the eDSL implementation based on the AST, |
flaub
approved these changes
Oct 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept
TensorDims for therepeatsparameter of the oplib functionrepeat. This is intended to help us avoidcompute_shapein the OV Bucketize code in plaidml/openvino#90