This repository was archived by the owner on Mar 29, 2025. It is now read-only.
Add repeat function declaration of TensorDim version.#1523
Closed
YangleiZouIntel wants to merge 1 commit intoplaidml-v1from
Closed
Add repeat function declaration of TensorDim version.#1523YangleiZouIntel wants to merge 1 commit intoplaidml-v1from
YangleiZouIntel wants to merge 1 commit intoplaidml-v1from
Conversation
Contributor
|
In order to use TendorDim for repeatOp, need to change the declaration of repeat, but not sure add a overload version or keep one version with edsl::Value argument, which is better. |
Signed-off-by: xin1.wang <xin1.wang@intel.com>
Contributor
|
Thanks for correcting my oversight here! Regarding overload vs. |
Contributor
|
Closing this in favor of #1524. See my previous comment for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xin1.wang xin1.wang@intel.com