Add code to handle replacing $eye variables in case the eyes are not …#43
Merged
piuccio merged 2 commits intopiuccio:masterfrom Nov 5, 2018
Merged
Add code to handle replacing $eye variables in case the eyes are not …#43piuccio merged 2 commits intopiuccio:masterfrom
piuccio merged 2 commits intopiuccio:masterfrom
Conversation
…adjacent to each other
Contributor
Author
|
Note, the /g in the regex is not included, so that only the first instance of $eye is replaced with the first character of $eyes, and second instance of $eye is replaced with the second character of $eyes. |
piuccio
reviewed
Nov 2, 2018
lib/replacer.js
Outdated
| @@ -1,5 +1,7 @@ | |||
| module.exports = function (cow, variables) { | |||
| var eyes = escapeRe(variables.eyes); | |||
| var eyeL = eyes.substr(0,1); | |||
Owner
There was a problem hiding this comment.
From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr
Can you please use eyeL = eyes.charAt(0); and eyeR = eyes.charAt(1); it's more readable.
Owner
|
Looks good, I was wondering if we should support any number of eyes but I guess all files have 2 eyes |
ofarukcaki
pushed a commit
to ofarukcaki/cowsay
that referenced
this pull request
Jul 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add code to handle replacing $eye variables in case the eyes are not adjacent to each other