Skip to content

Fix AV1 IVF writer using RTP depacketizer#3041

Merged
JoTurk merged 1 commit intomasterfrom
fix/av1-ivf
Mar 1, 2025
Merged

Fix AV1 IVF writer using RTP depacketizer#3041
JoTurk merged 1 commit intomasterfrom
fix/av1-ivf

Conversation

@JoTurk
Copy link
Copy Markdown
Member

@JoTurk JoTurk commented Feb 24, 2025 •
edited
Loading

description

  1. Replaced the OBU reader with the AV1 depacketizer to actually handle
    RTP input.
  2. Now explicitly constructing OBUTemporalDelimiter to ensure proper
    separation of frames.

base: pion/rtp#291

reference issue

#3036

This was referenced Feb 24, 2025
Merged
Closed
@JoTurk JoTurk mentioned this pull request Feb 25, 2025
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.42%. Comparing base (38fdb70) to head (fd7fe3f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/media/ivfwriter/ivfwriter.go 87.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3041   +/-   ##
=======================================
  Coverage   78.41%   78.42%           
=======================================
  Files          91       91           
  Lines       11265    11282   +17     
=======================================
+ Hits         8834     8848   +14     
- Misses       1940     1943    +3     
  Partials      491      491
Flag Coverage Δ
go 80.29% <87.50%> (+<0.01%) ⬆️
wasm 63.68% <87.50%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoTurk JoTurk marked this pull request as ready for review March 1, 2025 20:27
@JoTurk
Fix AV1 IVF writer using RTP depacketizer
fd7fe3f 
1. Replaced the OBU reader with the AV1 depacketizer to actually handle
RTP input.
2. Now explicitly constructing OBUTemporalDelimiter to ensure proper
separation of frames.
@JoTurk JoTurk merged commit fd7fe3f into master Mar 1, 2025
18 checks passed
@JoTurk JoTurk deleted the fix/av1-ivf branch March 1, 2025 21:46
@xgopilot xgopilot bot mentioned this pull request Jan 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sean-Der Sean-Der Sean-Der approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoTurk @Sean-Der