Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (74a4302) to head (48e175c).
Report is 1 commits behind head on master.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   85.18%   85.89%   +0.70%     
==========================================
  Files          25       26       +1     
  Lines        2788     2913     +125     
==========================================
+ Hits         2375     2502     +127     
+ Misses        354      352       -2     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeturki I am in support of merging and testing + improving after! The faster others can use it the sooner we get good feedback

I saw the GStreamer devs point out some pion bugs. I bet if you @ them they would be willing to test.

Thank you so much for doing this. So much complexity I was feeling intimidated by it

@joeturki I am in support of merging and testing + improving after! The faster others can use it the sooner we get good feedback

I just want to set a real integration test to make sure then we good :) I'm just not sure about IsPartitionTail.

I saw the GStreamer devs point out some pion bugs. I bet if you @ them they would be willing to test.

Yeah I self assigned that Issue :) I didn't know that they will be willing to help, I played with that a bit last month, and it's on my todo list for the packetizer fix, I'll make the PR after this :)

@Sean-Der hello this is ready now, it now reconstruct the OBUs with obu_size, I tested it with this pion/webrtc#3041 and ffplay, btw the jsfiddle in the save-to-disk-av1 is incorrect (it has "audio: true") can you please fix it if you can edit the link? :) I can make a new one too.

Amazing work @joeturki

I can't edit the jsfiddle :( mind just making a new one?

Do you have a LinkedIn yet? If not you should post about this (and I can re-share it). Best way to find work in the future :)

@Sean-Der I added more tests mainly around non-standard packets (packets with obu_size) to make sure we get valid packets.

Thank you, I'll post about it after the packetizer, Been testing it, I need to write a lot of tests, I'll make the PR today or tomorrow.

Also I'll fix the jsfiddle and the AV1 examples after that.
So 1) the packetizer PR, then we'll release a new RTP version, then I'll merge the IVF writer, and make sure the reader is correct, and I'll test & fix all the av1 examples in the WebRTC package.

Cool.