Skip to content

Tighten settings nav and add Escape back navigation#1503

Merged
juliusmarminge merged 1 commit intomainfrom
feature/settings-nav-escape
Mar 28, 2026
Merged

Tighten settings nav and add Escape back navigation#1503
juliusmarminge merged 1 commit intomainfrom
feature/settings-nav-escape

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Mar 28, 2026

  • Reduce settings sidebar typography for a denser layout
  • Close settings with Escape by navigating back

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk UI/UX-only change; main risk is unintended navigation when pressing Escape in focused inputs or modal flows within settings.

Overview
Settings UI is made denser and easier to exit. The settings sidebar nav and Back button reduce typography from text-sm to text-xs for a tighter layout.

Adds a global keydown handler on the settings route so pressing Escape calls window.history.back() (mirroring the existing Back button behavior), with proper listener cleanup on unmount.

Written by Cursor Bugbot for commit f6e4970. This will update automatically on new commits. Configure here.

Note

Add Escape key back navigation and tighten settings sidebar text size

  • Registers a keydown listener in SettingsContentLayout that calls window.history.back() on Escape, unless the event is already handled elsewhere.
  • Reduces sidebar nav and Back button text from text-sm to text-xs in SettingsSidebarNav.tsx.

Macroscope summarized f6e4970.

- Reduce settings sidebar typography for a denser layout
- Close settings with Escape by navigating back
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 28, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d212c4ec-e761-468a-8c66-a8384d32e74e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/settings-nav-escape

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Mar 28, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) March 28, 2026 21:59
@juliusmarminge juliusmarminge merged commit c426452 into main Mar 28, 2026
11 checks passed
@juliusmarminge juliusmarminge deleted the feature/settings-nav-escape branch March 28, 2026 22:01
Chrono-byte pushed a commit to Chrono-byte/t3code that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant