Skip to content

Preserve git action progress until HTTP completion#1388

Merged
juliusmarminge merged 1 commit intomainfrom
t3code/stacked-git-progress-bug
Mar 24, 2026
Merged

Preserve git action progress until HTTP completion#1388
juliusmarminge merged 1 commit intomainfrom
t3code/stacked-git-progress-bug

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Mar 24, 2026

Summary

  • Keep git action toast progress visible after action_finished and action_failed WebSocket events.
  • Defer clearing progress timestamps until the HTTP success/error handler updates the final toast state.
  • Prevents a brief flash where the toast loses its elapsed-time text before completion is rendered.

Testing

  • Not run (PR description only).
  • Verified the change is limited to apps/web/src/components/GitActionsControl.tsx and only adjusts toast state timing.

Note

Low Risk
Low risk UI-only change that adjusts when toast progress timestamps are cleared; potential impact is limited to git action progress toast rendering timing.

Overview
Prevents the git action progress toast from losing its elapsed-time description between action_finished/action_failed WebSocket events and the final HTTP success/error response.

This changes the progress event handler in GitActionsControl.tsx to not clear progress timestamps on WS completion events, deferring final toast state management to the HTTP handlers to avoid a brief “bare title” toast flash.

Written by Cursor Bugbot for commit 650c9c7. This will update automatically on new commits. Configure here.

Note

Preserve git action progress display until HTTP response completes

Previously, action_finished and action_failed WebSocket events in GitActionsControl.tsx immediately cleared timing fields and updated the loading toast, causing the running duration to disappear before the HTTP response arrived. Now both events return early without modifying state, leaving the HTTP response handler to finalize the toast and clear activeGitActionProgressRef.

Macroscope summarized 650c9c7.

- Keep progress timestamps intact on `action_finished` and `action_failed`
- Let the HTTP response path clear the active toast so the running description does not flash away
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3647b075-50a3-4ede-b786-998311a223a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/stacked-git-progress-bug

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Mar 24, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) March 24, 2026 23:37
@juliusmarminge juliusmarminge merged commit 56d13fa into main Mar 24, 2026
11 checks passed
@juliusmarminge juliusmarminge deleted the t3code/stacked-git-progress-bug branch March 24, 2026 23:38
waaeel added a commit to dinweldik/fatma that referenced this pull request Mar 25, 2026
Merged upstream improvements while preserving fork identity:
- Claude Code adapter support (pingdotgg#179)
- Context window usage meter (pingdotgg#1351)
- Sidebar project/thread sorting by recency (pingdotgg#1372)
- Git action progress streaming (pingdotgg#1214, pingdotgg#1388)
- Terminal history ANSI preservation (pingdotgg#1367)
- Word wrapping setting (pingdotgg#1326)
- Resizable chat sidebar (pingdotgg#1347)
- Configurable timestamp format (pingdotgg#855)
- Selective file staging in commit dialog (pingdotgg#872)
- Fuzzy workspace search (pingdotgg#256)
- Scroll-to-bottom pill (pingdotgg#619)
- Numerous bug fixes and improvements

Preserved fork customizations:
- Fatma branding (all @t3tools -> @fatma)
- Mobile UI (swipe gestures, bottom nav, mobile shells)
- VSCode-like source control (staged/unstaged, file diffs)
- PWA support
- Custom CI/CD workflows

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
emrezeytin pushed a commit to emrezeytin/t3code that referenced this pull request Mar 25, 2026
apexsloth pushed a commit to apexslothforks/t3code that referenced this pull request Mar 26, 2026
Chrono-byte pushed a commit to Chrono-byte/t3code that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant