oxc stack by juliusmarminge · Pull Request #1 · pingdotgg/t3code

juliusmarminge · 2026-02-09T04:33:02Z

the biome binary has crashed my computer enough times that i don't want it anywhere near htis machine...

Summary by CodeRabbit

Chores
- Upgraded package manager from Bun 1.1.38 to 1.3.9.
- Replaced Biome with oxfmt and oxlint; added related workspace/editor config and formatter/linter settings.
- Updated TypeScript compilation target to ES2023.
- Removed redundant lint configuration and related scripts.
New Features
- Added a resolveModelSlug utility to normalize and validate model identifiers.
Bug Fixes
- Improved error handling by chaining original errors as causes.

coderabbitai · 2026-02-09T04:33:16Z

Caution

Review failed

The pull request is closed.

Walkthrough

Migrates formatting/linting from Biome to Oxfmt/Oxlint, adds VSCode Oxc recommendations/settings, upgrades Bun and TypeScript targets to newer versions, introduces a new exported helper resolveModelSlug, and applies widespread formatting/refactor-style changes plus one error chaining improvement.

Changes

Cohort / File(s)	Summary
Tooling & Editor config `./.oxfmtrc.json`, `./.oxlintrc.json`, `./.vscode/extensions.json`, `./.vscode/settings.json`, `./biome.json`	Add Oxfmt/Oxlint configs and VSCode recommendations/settings; remove `biome.json`. Check ignorePatterns and plugin/rule toggles in `.oxlintrc.json`.
Repository root config `./package.json`, `./turbo.json`, `./tsconfig.base.json`, `./README.md`	Replace Biome tooling with `oxfmt`/`oxlint`, update scripts (`lint` → `oxlint`, add `fmt`), add Bun engine and update `packageManager` to `bun@1.3.9`, remove top-level `lint` turbo task, bump TS target/lib to ES2023, and minor README formatting.
Desktop app scripts & package `apps/desktop/package.json`, `apps/desktop/scripts/dev-electron.mjs`, `apps/desktop/tsconfig.json`	Switch dev script from `concurrently` to `bun run --parallel`, remove `lint` script and `concurrently` devDependency, and bump TS lib to ES2023; minor script formatting changes.
Desktop app internals `apps/desktop/src/codexAppServerManager.ts`, `apps/desktop/src/main.ts`, `apps/desktop/src/preload.ts`, `apps/desktop/src/processManager.ts`, `apps/desktop/src/todoStore.ts`, `apps/desktop/src/*test.ts`	Primarily formatting (many multi-line -> single-line refactors). Note: `startSession` error throw now includes original error as `cause`; `runTerminalCommand` signature formatting simplified. Tests and helpers reformatted only.
Renderer app config & styling `apps/renderer/package.json`, `apps/renderer/tsconfig.json`, `apps/renderer/src/index.css`	Remove renderer lint script, bump TS lib to ES2023, minor CSS formatting adjustments.
Renderer components & logic `apps/renderer/src/components/ChatMarkdown.tsx`, `apps/renderer/src/components/ChatView.tsx`, `apps/renderer/src/components/DiffPanel.tsx`, `apps/renderer/src/components/Sidebar.tsx`, `apps/renderer/src/persistenceSchema.ts`, `apps/renderer/src/session-logic.ts`, `apps/renderer/src/*test.ts`	Mostly stylistic and minor behavior-preserving refactors. Notable logic change: use of `.toReversed()` instead of `.reverse()` to avoid mutation in reversal logic. Various UI class/token updates.
Contracts package: types & API `packages/contracts/package.json`, `packages/contracts/src/ipc.ts`, `packages/contracts/src/model.ts`, `packages/contracts/src/provider.ts`, `packages/contracts/src/*test.ts`	Add `files: ["dist"]` canonicalization in package.json and remove redundant entry; reflow type/signature formatting; add exported `resolveModelSlug(model)` function (normalizes and falls back to `DEFAULT_MODEL`).
Misc tests & small utilities `apps/desktop/src/ipcHelpers.test.ts`, `packages/contracts/src/model.test.ts`, `apps/renderer/src/model-logic.test.ts`, other small files	Formatting-only updates to imports, expectations, and helper signatures; no behavioral changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

oxc stack #1 — Repository-level tooling migration and configuration changes (adds .oxfmtrc/.oxlintrc, VSCode Oxc settings, replaces Biome with Oxfmt/Oxlint); appears to mirror this PR's migration work.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 7.14% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'oxc stack' refers to a core aspect of the changeset—replacing Biome with the Oxc linting/formatting toolchain—but is vague and could be unclear to someone unfamiliar with the project.	Consider a more descriptive title like 'Replace Biome with Oxc toolchain' to clearly communicate the main change to reviewers scanning the history.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch juliusmarminge/barcelona

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

macroscopeapp · 2026-02-09T04:34:14Z

Adopt the oxc stack by replacing repository linting/formatting with `oxlint` and `oxfmt`, updating Bun to `>=1.3.9`, and switching `apps/desktop` dev to Bun’s parallel runner

Introduce oxfmt and oxlint with config files, remove Biome and concurrently, update Bun engine and lockfile, and add small ES2023/toReversed() refactors plus improved error causality in CodexAppServerManager.startSession.

📍Where to Start

Start with the root tooling changes in package.json, then review the formatter/linter configs in .oxfmtrc.json and .oxlintrc.json; for the sole logic change, see CodexAppServerManager.startSession in apps/desktop/src/codexAppServerManager.ts.

Macroscope summarized a6606e8.

* oxc stacak * kewl * unused * unused

…rowser (pingdotgg#1) * feat(web): project selection v.0.1 * feat(web): project selection v.1.0 * feat(project): harden project folder picker and add server-side directory browser Review-driven improvements to the add-project feature: - Security: validate paths against allowed filesystem roots (home + drives on Windows, home + / on POSIX) with trailing-separator prefix matching - Server: parallel stat with concurrency limit, entry cap, error message sanitization in WS handler - FolderPickerModal: fix state reset on reopen (ref pattern eliminates effect races), cross-platform breadcrumb paths, ARIA roles, useMemo optimizations - Sidebar: manual path input fallback for web (no native dialog), addProjectFromPath returns boolean so UI only clears on success - Contracts: maxLength on DirectoryListInput.path - Tests: 19 unit tests for listDirectory, isUnderAllowedRoot, getAllowedRoots Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Oleksandr <ace.7557@yahoo.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

- BrowserPanel.tsx: orchestrator with isElectron detection - BrowserPanelShell.tsx: container UI (same pattern as DiffPanelShell) - BrowserNavBar.tsx: URL bar + back/forward/refresh/close - BrowserWebview.tsx: Electron <webview> with isolated partition - BrowserIframe.tsx: localhost-only iframe fallback for web mode - browserPanelStore.ts: Zustand store for URL/nav state - browserRouteSearch.ts: search params ?browser=1&browserUrl=xxx - Keybinding: browser.toggle (mod+b) - Toggle button: GlobeIcon in ChatHeader (after editor, before diff) - Layout: RightPanel sidebar after DiffPanel (desktop + mobile sheet) - Desktop main.ts: webviewTag: true in webPreferences - CSS: browser-loading keyframe animation - Tests: 20 passing (browserRouteSearch + browserPanelStore) - Zero conflict with PR pingdotgg#1: additions-only in shared files

…e inputUrl store duplication - Resolve all merge conflicts with PR pingdotgg#1 (feat/monaco-editor-panel) - Both panels coexist: editor toggle before diff, browser toggle after - Validate URL with isValidBrowserUrl() before shell.openExternal() - Remove dead inputUrl/setInputUrl from browserPanelStore (BrowserNavBar uses local state) - Migrate from custom Sidebar/Sheet wrappers to shared RightPanelPrimitives - Add BROWSER_PANEL_SEARCH_PARAMS to RightPanelPrimitives.tsx

- BrowserPanel.tsx: orchestrator with isElectron detection - BrowserPanelShell.tsx: container UI (same pattern as DiffPanelShell) - BrowserNavBar.tsx: URL bar + back/forward/refresh/close - BrowserWebview.tsx: Electron <webview> with isolated partition - BrowserIframe.tsx: localhost-only iframe fallback for web mode - browserPanelStore.ts: Zustand store for URL/nav state - browserRouteSearch.ts: search params ?browser=1&browserUrl=xxx - Keybinding: browser.toggle (mod+b) - Toggle button: GlobeIcon in ChatHeader (after editor, before diff) - Layout: RightPanel sidebar after DiffPanel (desktop + mobile sheet) - Desktop main.ts: webviewTag: true in webPreferences - CSS: browser-loading keyframe animation - Tests: 20 passing (browserRouteSearch + browserPanelStore) - Zero conflict with PR pingdotgg#1: additions-only in shared files

Remote Agent (SSH) and Full Diff View

- Add CODEX_INTEGRATION_ANALYSIS.md with detailed protocol flow analysis * Protocol flow architecture and high-level overview * Request-response JSON-RPC sequence diagrams * Event streaming and transformation pipeline * Session state machine and lifecycle events * Provider dispatch routing analysis * 5 critical improvements ranked by priority * Failure scenarios and recovery analysis * Testing and deployment recommendations - Add CODEX_IMPROVEMENTS_GUIDE.md with step-by-step implementation guide * Improvement pingdotgg#1: Method-specific timeout configuration * Improvement pingdotgg#2: Partial stream recovery buffer * Improvement pingdotgg#3: Circuit breaker pattern implementation * Improvement pingdotgg#4: Graceful shutdown with timeout * Improvement pingdotgg#5: Structured observability logging * Integration checklist and testing procedures * 5-week rollout strategy Architecture grade: B+ (strong foundation, operational concerns remain) Expected impact: 10x reduction in false timeouts, 99.9% → 99.99% availability These guides provide actionable recommendations for improving connection robustness, timeout strategies, error recovery, and observability in the Codex App Server integration.

juliusmarminge added 4 commits February 9, 2026 01:10

oxc stacak

7ca09fd

kewl

e25264b

unused

def996f

unused

a6606e8

t3dotgg force-pushed the juliusmarminge/barcelona branch from 71948e8 to a6606e8 Compare February 9, 2026 09:11

t3dotgg merged commit 70a9a04 into main Feb 9, 2026
2 checks passed

Xenoifyteam mentioned this pull request Mar 7, 2026

Per-project MCP #276

Closed

kimkhoi2202 mentioned this pull request Mar 7, 2026

Per-project MCP #277

Open

eliesgalvira mentioned this pull request Mar 9, 2026

[Bug] Large diffs cause commit/push/PR action to fail. #413

Closed

binbandit mentioned this pull request Mar 11, 2026

feat(github): add issue templates for automatic triage #896

Merged

jjalangtry pushed a commit to jjalangtry/t3code that referenced this pull request Mar 16, 2026

oxc stack (pingdotgg#1)

9515851

* oxc stacak * kewl * unused * unused

praveenperera pushed a commit to praveenperera/t3code that referenced this pull request Mar 23, 2026

Merge pull request pingdotgg#1 from ntheile/remote-agent

4debba8

Remote Agent (SSH) and Full Diff View

juliusmarminge mentioned this pull request Apr 1, 2026

perf(server): avoid thread-wide scans for message projection #1647

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

oxc stack#1

oxc stack#1
t3dotgg merged 4 commits intomainfrom
juliusmarminge/barcelona

juliusmarminge commented Feb 9, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 9, 2026 •

edited

Loading

Review failed

Uh oh!

macroscopeapp bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

juliusmarminge commented Feb 9, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

macroscopeapp bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Adopt the oxc stack by replacing repository linting/formatting with oxlint and oxfmt, updating Bun to >=1.3.9, and switching apps/desktop dev to Bun’s parallel runner

📍Where to Start

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

juliusmarminge commented Feb 9, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 9, 2026 •

edited

Loading

macroscopeapp bot commented Feb 9, 2026 •

edited

Loading

Adopt the oxc stack by replacing repository linting/formatting with `oxlint` and `oxfmt`, updating Bun to `>=1.3.9`, and switching `apps/desktop` dev to Bun’s parallel runner