Allow merge the existing description/workaround in errors.toml#867
Merged
Allow merge the existing description/workaround in errors.toml#867
Conversation
Signed-off-by: Lonng <heng@lonng.org>
Codecov Report
@@ Coverage Diff @@
## master #867 +/- ##
===========================================
- Coverage 53.06% 21.12% -31.94%
===========================================
Files 263 234 -29
Lines 19038 17223 -1815
===========================================
- Hits 10102 3638 -6464
- Misses 7370 13072 +5702
+ Partials 1566 513 -1053
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
july2993
reviewed
Oct 29, 2020
Contributor
july2993
left a comment
There was a problem hiding this comment.
LGTM
release note should know what component updated.
and I think the user no need to know about this errdoc-gen
lucklove
pushed a commit
that referenced
this pull request
Oct 30, 2020
Signed-off-by: Lonng <heng@lonng.org>
This was referenced Oct 30, 2020
This was referenced Nov 9, 2020
This was referenced Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
Allow merge the existing description/workaround in errors.toml
What is changed and how it works?
Open the existing errors.toml and merge the
description/workaroundif the previous error metafile contains these values.Check List
Tests
Release notes: