integration_test (ticdc): set global tidb_enable_clustered_index = INT_ONLY before execute any SQL#7534
Conversation
…ongmen/ticdc into dongmen/set_safemode_for_redo_apply
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
|
@tangenta: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| other=${*} | ||
| fi | ||
|
|
||
| prepare="set global tidb_enable_clustered_index = 'int_only';" |
There was a problem hiding this comment.
Could you please add a comment for it?
|
Please refine your PR title and body. Thanks! |
tidb_enable_clustered_index = INT_ONLY before execute any SQL
|
/run-all-tests |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7534 +/- ##
================================================
- Coverage 59.8343% 59.8234% -0.0110%
================================================
Files 804 816 +12
Lines 92365 93323 +958
================================================
+ Hits 55266 55829 +563
- Misses 32287 32648 +361
- Partials 4812 4846 +34 |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: b4ddd72 |
|
/run-check-issue-triage-complete |
What problem does this PR solve?
Issue Number: close #7535
What is changed and how it works?
After pingcap/tidb#37384 was merged,
tidb_enable_clustered_indexisONby default.Some TiCDC integration test cases need to drop a table's primary key, but if the primary key is a clustered index, it can't be droped.
This PR set
global tidb_enable_clustered_index = INT_ONLYwhen we connect to upstream TiDB in integration test, which is a workaround to make the integration test cases works as before.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note