Skip to content

sessionctx: enable clustered index by default#37384

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
tangenta:cluster-index-enable1
Sep 1, 2022
Merged

sessionctx: enable clustered index by default#37384
ti-chi-bot merged 5 commits intopingcap:masterfrom
tangenta:cluster-index-enable1

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Aug 25, 2022

What problem does this PR solve?

Problem Summary:

The "clustered index" feature has been GA in release-5.0. We decide to change the default value of tidb_enable_clustered_index to ON, with the following advantages:

  • The point get performance in certain scenarios can be improved.
  • Compared with the original default value INT_ONLY, it is easier to understand for new users.

What is changed and how it works?

This PR changes the default value of tidb_enable_clustered_index to ON.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tangenta tangenta added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 25, 2022
@tangenta tangenta requested a review from a team as a code owner August 25, 2022 09:35
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2022
jackysp
jackysp reviewed Aug 25, 2022
View reviewed changes
Copy link
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you change it now?

@tangenta
Copy link
Contributor Author

tangenta commented Aug 26, 2022

@jackysp It is planned in the next release.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 29, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 29, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/565fd446e6c93f39622695618fb6ac42a5c53b8d

@hawkingrei
Copy link
Member

hawkingrei commented Aug 29, 2022

/run-all-tests

@jackysp
Copy link
Contributor

jackysp commented Aug 30, 2022

There is a risk that TiDB does not support alter primary key yet, so if clustered index is enabled by default, users will have to rebuild the table if they find a serious hotspot problem. @tangenta

@bb7133
Copy link
Member

bb7133 commented Sep 1, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 1, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 565fd44

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2022
@bb7133 bb7133 added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Sep 1, 2022
@bb7133
Copy link
Member

bb7133 commented Sep 1, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit ed7afe6 into pingcap:master Sep 1, 2022
@tangenta tangenta mentioned this pull request Sep 1, 2022
Merged
13 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Sep 1, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 17 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 13 min Existing failure
idc-jenkins-ci-tidb/integration-compatibility-test ✅ all 1 tests passed 8 min 44 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 3 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 59 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 49 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 50 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@Oreoxmt Oreoxmt mentioned this pull request Sep 2, 2022
Merged
12 tasks
@tangenta tangenta mentioned this pull request Oct 13, 2022
Merged
12 tasks
@asddongmen asddongmen mentioned this pull request Nov 6, 2022
Merged
@JaySon-Huang JaySon-Huang mentioned this pull request Nov 6, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 7, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackysp jackysp jackysp left review comments

@ngaut ngaut ngaut approved these changes

@bb7133 bb7133 bb7133 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees

No one assigned

Labels

compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tangenta @ti-chi-bot @hawkingrei @jackysp @bb7133 @sre-bot @ngaut