Skip to content

Storages: use default string type in DeltaMergeStore#9990

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
JinheLin:force_to_stringv2_in_storage
Mar 12, 2025
Merged

Storages: use default string type in DeltaMergeStore#9990
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
JinheLin:force_to_stringv2_in_storage

Conversation

@JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Mar 11, 2025 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9983

What is changed and how it works?

- Converting string type to default parameter in DeltaMergeStore

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • Compacting tiflash replica make string data from String to StringV2.

image

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix a bug that the string serialize method of existing data does not follow `storage.format_version` after upgraded

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2025
JaySon-Huang
JaySon-Huang reviewed Mar 11, 2025
View reviewed changes
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 11, 2025
@JinheLin @JaySon-Huang
Update dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp
706b97f 
Co-authored-by: JaySon <tshent@qq.com>
@JinheLin JinheLin requested a review from JaySon-Huang March 11, 2025 11:24
@JinheLin
Copy link
Contributor Author

JinheLin commented Mar 11, 2025

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 12, 2025
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Mar 12, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2025
@JaySon-Huang
Add tests
f6eeeb4 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Mar 12, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 12, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-12 01:12:54.808802009 +0000 UTC m=+318330.414330930: ☑️ agreed by JaySon-Huang.
  • 2025-03-12 01:39:32.289271354 +0000 UTC m=+319927.894800281: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit 72df70c into pingcap:master Mar 12, 2025
5 checks passed
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Mar 12, 2025

/cherry-pick release-9.0-beta.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2025

@JaySon-Huang: new pull request created to branch release-9.0-beta.1: #9993.

Details

In response to this:

/cherry-pick release-9.0-beta.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 12, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Mar 12, 2025
@ti-chi-bot @JinheLin @JaySon-Huang
Storages: use default string type in DeltaMergeStore (#9990) (#9993)
fe12cdd 
close #9983

- Converting string type to default parameter in DeltaMergeStore

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: jinhelin <linjinhe33@gmail.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: JaySon <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees

No one assigned

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The new string deserialization method is not applied to the existing table columns before upgrade

4 participants

@JinheLin @JaySon-Huang @ti-chi-bot @Lloyd-Pottiger