Columns: optimize ColumnString filter when selectivity is high#9987
Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom Mar 12, 2025
Merged
Columns: optimize ColumnString filter when selectivity is high#9987ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
Conversation
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
gengliqi
reviewed
Mar 12, 2025
dbms/src/Columns/filterColumn.cpp
Outdated
Comment on lines
+250
to
+251
| if (index + length == FILTER_SIMD_BYTES) | ||
| break; |
Contributor
There was a problem hiding this comment.
How about adding a predefined mask table?
constexpr uint64_t MASKS[65] = [] {
uint64_t masks[65] = {};
for (int i = 0; i < 64; ++i) {
masks[i] = ~((1ULL << i) - 1);
}
masks[64] = 0;
return masks;
}();
mast &= MASKS[index + length];Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
windtalker
reviewed
Mar 12, 2025
Contributor
windtalker
left a comment
There was a problem hiding this comment.
Do we have some existing test for this?
gengliqi
approved these changes
Mar 12, 2025
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
/cherry-pick release-9.0-beta.1 |
Member
|
@JaySon-Huang: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
12 tasks
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
#10036) ref #9699, close #10029 optimize the performance of ColumnString filter when the selectivity of filter is high: For example, when filter is `0111111111111111011111111111111101111111111111110111111111111111`, the mask will be `11111111111111110111111111111111101111111111111111011111111111111110`, since it does not be `[0]*[1]+` or `[1]+[0]*`, we need to copy each selected row one by one. Now, we can copy 15 rows at once. The total elapsed time of TPC-H 50 reduce from 42.9s to 41.1s. Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: Lloyd-Pottiger <yan1579196623@gmail.com> Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com> Co-authored-by: JaySon-Huang <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9699, close #10029
Problem Summary:
What is changed and how it works?
following optimization of #9670
Check List
Tests
Side effects
Documentation
Release note