Skip to content

Storages: fix adding delta vector index does not work with existing indexes (#9975)#9979

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-9975-to-release-8.5
Mar 28, 2025
Merged

Storages: fix adding delta vector index does not work with existing indexes (#9975)#9979
ti-chi-bot[bot] merged 5 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-9975-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 11, 2025

This is an automated cherry-pick of #9975

What problem does this PR solve?

Issue Number: close #9971, close #9972

Problem Summary:

What is changed and how it works?

1. Fix the existing index infoes in ColumnFileTiny are missed after add new indexes.
2. Do not add task into `LocalIndexerScheduler` if the DMFile is empty.
3. Fix delta data do not build the new added local indexes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue where adding new vector indexes could result in performance regression due to accidental removal of existing vector indexes

@Lloyd-Pottiger @ti-chi-bot
This is an automated cherry-pick of pingcap#9975
127570f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Mar 11, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 11, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 11, 2025

@Lloyd-Pottiger This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@Lloyd-Pottiger
fix conflicts
e96763d 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Mar 11, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2025
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Mar 11, 2025

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 11, 2025

@JaySon-Huang: It seems you want to approve this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 11, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 28, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 28, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-28 01:36:40.394010592 +0000 UTC m=+1183494.078246688: ☑️ agreed by JaySon-Huang.
  • 2025-03-28 02:02:51.091960798 +0000 UTC m=+1185064.776196893: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2025

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1f51486 into pingcap:release-8.5 Mar 28, 2025
4 checks passed
JaySon-Huang added a commit to ti-chi-bot/tiflash that referenced this pull request Mar 31, 2025
@ti-chi-bot @Lloyd-Pottiger
@JaySon-Huang @ti-chi-bot
Storages: fix adding delta vector index does not work with existing i…
23f16ce 
…ndexes (pingcap#9975) (pingcap#9979)

close pingcap#9971, close pingcap#9972

1. Fix the existing index infoes in ColumnFileTiny are missed after add new indexes.
2. Do not add task into `LocalIndexerScheduler` if the DMFile is empty.
3. Fix delta data do not build the new added local indexes.

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

Co-authored-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

@Lloyd-Pottiger Lloyd-Pottiger

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @JaySon-Huang @Lloyd-Pottiger