Skip to content

Fix nullptr arena in aggregation window function#9968

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
xzhangxian1008:fix-9964
Mar 10, 2025
Merged

Fix nullptr arena in aggregation window function#9968
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
xzhangxian1008:fix-9964

Conversation

@xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Mar 10, 2025

What problem does this PR solve?

Issue Number: close #9964

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that arena is nullptr in aggregation window function

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2025
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Mar 10, 2025

/cc @windtalker @guo-shaoge

@ti-chi-bot ti-chi-bot bot requested review from guo-shaoge and windtalker March 10, 2025 01:56
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Mar 10, 2025

/cc @yibin87

@ti-chi-bot ti-chi-bot bot requested a review from yibin87 March 10, 2025 02:32
windtalker
windtalker approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved and removed do-not-merge/needs-triage-completed labels Mar 10, 2025
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Mar 10, 2025

/cc @yibin87

yibin87
yibin87 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-10 02:33:45.081148741 +0000 UTC m=+150380.686677663: ☑️ agreed by windtalker.
  • 2025-03-10 05:02:11.709551063 +0000 UTC m=+159287.315079990: ☑️ agreed by yibin87.

@ti-chi-bot ti-chi-bot bot merged commit f2d51fd into pingcap:master Mar 10, 2025
5 checks passed
@xzhangxian1008 xzhangxian1008 deleted the fix-9964 branch March 10, 2025 09:01
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Mar 11, 2025

/cherrypick release-8.5-20250310-v8.5.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2025

@xzhangxian1008: new pull request created to branch release-8.5-20250310-v8.5.1: #9985.

Details

In response to this:

/cherrypick release-8.5-20250310-v8.5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 11, 2025
Merged
12 tasks
ti-chi-bot bot added a commit that referenced this pull request Mar 11, 2025
@ti-chi-bot @xzhangxian1008 @ti-chi-bot
Fix nullptr arena in aggregation window function (#9968) (#9985)
eb8944e 
close #9964

Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@yibin87 yibin87 yibin87 approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

Assignees

No one assigned

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Arena is nullptr in aggregation window function in some case

4 participants

@xzhangxian1008 @ti-chi-bot @windtalker @yibin87