Fix memory leak in aggregation function in window#9933
Fix memory leak in aggregation function in window#9933ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
Conversation
|
/cc @windtalker @yibin87 |
|
/cc @windtalker @yibin87 |
|
/retest |
| } | ||
| } | ||
|
|
||
| agg_func->reset(agg_state.data()); |
There was a problem hiding this comment.
why not use destroy here?
There was a problem hiding this comment.
why not use destroy here?
done
Origin tests could cover the memory leak case. |
|
/cc @windtalker @yibin87 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/cherrypick release-8.5-20250310-v8.5.1 |
|
@xzhangxian1008: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #9930
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note