fix virtual column not found when remote read happens#9920
fix virtual column not found when remote read happens#9920ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
Conversation
e0e1759 to
2924572
Compare
Signed-off-by: guo-shaoge <shaoge1994@163.com>
2924572 to
3ae266b
Compare
d1ba195 to
30a4e3d
Compare
ac77a2e to
633f195
Compare
Signed-off-by: guo-shaoge <shaoge1994@163.com>
74e1daf to
f9d85ec
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: solotzg, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
…ingcap#9928) close pingcap#9561 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: guo-shaoge <shaoge1994@163.com> Co-authored-by: guo-shaoge <shaoge1994@163.com>
What problem does this PR solve?
Issue Number: close #9561
Problem Summary:
gen_col is a virtual generated column. The current approach is that TiFlash generates an empty column and places it in the block. Then, it passes the block to TiDB, allowing TiDB to calculate and populate the column.
I’ve named this column generated_xxx.
The information about this column is marked in tipb_table_scan.columns with a flag. When TiFlash sees this flag, it automatically adds a generated_xxx column.
However, this situation has an issue when a remote read occurs: the block returned from the remote read, when parsed, assigns names to each column based on RemoteRequest.schema. For example, if TiFlash-1 receives a block from TiFlash-2, it will parse it as <col, gen_col>.
But TiFlash-1, in the table scan's projection, expects the block to be <col, generated_xxx>. So, when projecting the block from the remote read, an error occurs because it cannot find the generated_xxx column.
What is changed and how it works?
make the column name of local read and remote read be same
Check List
Tests
Side effects
Documentation
Release note