Storage: Fix init_thread_count_scale == 0, tiflash can not start normally#9905
Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom Feb 24, 2025
Merged
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger
approved these changes
Feb 24, 2025
JinheLin
approved these changes
Feb 24, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
Author
|
/hold |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
Author
|
/unhold |
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot bot
added a commit
that referenced
this pull request
Feb 25, 2025
…ally (#9905) (#9907) close #9906 * If `profiles.default.init_thread_count_scale == 0`, run `loadMetadata` and `BgStorageInit` in serial order. * Respect `terminate_signals_counter` in `BGStorageInit` Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
yongman
pushed a commit
to yongman/tiflash
that referenced
this pull request
Jun 18, 2025
…ally (pingcap#9905) (pingcap#9909) close pingcap#9906 * If `profiles.default.init_thread_count_scale == 0`, run `loadMetadata` and `BgStorageInit` in serial order. * Respect `terminate_signals_counter` in `BGStorageInit` Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9906
Problem Summary:
If
profiles.default.init_thread_count_scaleto 0, tiflash stuck at loading metadata because we try to add task into a thread pool with num_thread == 0.What is changed and how it works?
Check List
Tests
deploy a cluster and add this config line to tiflash by tiup edit-config
Side effects
Documentation
Release note