Skip to content

disagg: Adapt with the GetLifecycleConfig response on AWS S3#9888

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:fix_aws_lifecycle_check
Feb 19, 2025
Merged

disagg: Adapt with the GetLifecycleConfig response on AWS S3#9888
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JaySon-Huang:fix_aws_lifecycle_check

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Feb 18, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9889

Problem Summary:

We encounter some error logging as follow after the lifecycle is correctly added.

[2025/02/18 15:47:25.784 +00:00] [WARN] [S3Common.cpp:847] ["Create lifecycle rule with tag filter \"tiflash_deleted=true\" failed, please check the bucket lifecycle configuration or create the lifecycle rule manually, bucket=tiflash  s3error=UNKNOWN s3exception_name=InvalidArgument s3msg=Unable to parse ExceptionName: InvalidArgument Message: Rule ID must be unique. Found same ID for more than one rule request_id=WH14MR0TVK0DTGN5"] [source="bucket=tiflash root=tiflash_dev/"] [thread_id=371]
[2025/02/18 15:47:25.784 +00:00] [WARN] [S3Common.cpp:145] ["tag=AWSErrorMarshaller message=Encountered Unknown AWSError 'InvalidArgument': Rule ID must be unique. Found same ID for more than one rule"] [source=AWSClient] [thread_id=371]
[2025/02/18 15:47:25.729 +00:00] [INFO] [S3Common.cpp:816] ["The lifecycle rule with filter \"tiflash_deleted=true\" has not been added, n_rules=1"] [source="bucket=tiflash root=tiflash_dev/"] [thread_id=371]

What is changed and how it works?

* Adapt the logic of checking rule existence with the rule filter response on latest AWS S3
* Accept `AWS_SESSION_TOKEN` to run unit-test with temporary ak, sk, session_token

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@JaySon-Huang
Adapt with aws response
0f5aa47 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2025
@JaySon-Huang
Tune some logging level
752de5e 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Add mock test
b8c06dd 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-19 02:46:11.725515327 +0000 UTC m=+1015814.121737381: ☑️ agreed by Lloyd-Pottiger.
  • 2025-02-19 03:23:48.472428529 +0000 UTC m=+1018070.868650588: ☑️ agreed by JinheLin.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 19, 2025

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Feb 19, 2025

/run-all-tests

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Feb 19, 2025

/test pull-integration-test

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Feb 19, 2025

/test pull-unit-test

1 similar comment
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Feb 19, 2025

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 16d4a03 into pingcap:master Feb 19, 2025
5 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_aws_lifecycle_check branch February 19, 2025 06:15
yongman pushed a commit to yongman/tiflash that referenced this pull request Jun 18, 2025
@JaySon-Huang @ti-chi-bot
disagg: Adapt with the GetLifecycleConfig response on AWS S3 (pingcap…
6dc0e16 
…#9888)

close pingcap#9889

* Adapt the logic of checking rule existence with the rule filter response on latest AWS S3
* Accept `AWS_SESSION_TOKEN` to run unit-test with temporary ak, sk, session_token

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JinheLin JinheLin JinheLin approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ensureLifecycleRuleExist can not correctly parse the result of GetLifecycleConfig on latest AWS S3

3 participants

@JaySon-Huang @JinheLin @Lloyd-Pottiger