Skip to content

Fix the failure of finding correct current row when frame type is range in window function#9864

Merged
ti-chi-bot[bot] merged 82 commits intopingcap:masterfrom
xzhangxian1008:fix-range
Feb 17, 2025
Merged

Fix the failure of finding correct current row when frame type is range in window function#9864
ti-chi-bot[bot] merged 82 commits intopingcap:masterfrom
xzhangxian1008:fix-range

Conversation

@xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Feb 12, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9868

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that failure of finding correct current row when frame type is range in window function

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 14, 2025
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2025
windtalker
windtalker approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 14, 2025
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Feb 14, 2025

/cc @guo-shaoge

@ti-chi-bot ti-chi-bot bot requested a review from guo-shaoge February 14, 2025 13:12
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-14 09:27:47.588584833 +0000 UTC m=+607909.984806895: ☑️ agreed by windtalker.
  • 2025-02-17 02:47:20.176372393 +0000 UTC m=+843082.572594449: ☑️ agreed by guo-shaoge.

@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Feb 17, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Feb 17, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
@ti-chi-bot ti-chi-bot bot merged commit cc6a2ca into pingcap:master Feb 17, 2025
5 checks passed
@xzhangxian1008 xzhangxian1008 deleted the fix-range branch February 17, 2025 07:47
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Mar 11, 2025

/cherrypick release-8.5-20250310-v8.5.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2025

@xzhangxian1008: new pull request created to branch release-8.5-20250310-v8.5.1: #9981.

Details

In response to this:

/cherrypick release-8.5-20250310-v8.5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 11, 2025
@xzhangxian1008 @ti-chi-bot @ti-chi-bot
Fix the failure of finding correct current row when frame type is ran…
2fac46a 
…ge in window function (pingcap#9864)

close pingcap#9868

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 11, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Mar 11, 2025
@ti-chi-bot @xzhangxian1008
Fix the failure of finding correct current row when frame type is ran…
7de3e56 
…ge in window function (#9864) (#9981)

close #9868

Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't find correct current row when frame type is range in window function

4 participants

@xzhangxian1008 @ti-chi-bot @windtalker @guo-shaoge