vector: Reduce logging under debug level (#9852)#9858
Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from Feb 10, 2025
Merged
vector: Reduce logging under debug level (#9852)#9858ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Member
Author
|
@JaySon-Huang This PR has conflicts, I have hold it. |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
approved these changes
Feb 10, 2025
Contributor
|
/unhold |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Mar 4, 2025
pingcap#362) Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
yongman
pushed a commit
to yongman/tiflash
that referenced
this pull request
Jun 18, 2025
close pingcap#9854 * Move the logging from `generateLocalIndexInfos` to `DeltaMergeStore::applyLocalIndexChange`. Reduce logging that is not cause by DDL changed * Return the keep/added/dropped index ids in `LocalIndexInfosChangeset` and generate the changeset logging string by `LocalIndexInfosChangeset::toString` Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9852
What problem does this PR solve?
Issue Number: close #9854
Problem Summary:
When we try to add a vector index on a relative large table, there are much useless logging under debug level
system.dt_local_indexesfrom all tiflash instancesStorageSystemDTLocalIndexes::readcallgetLocalIndexesStatsFromStorage. For non-initedDeltaMergeStore, the function callsgenLocalIndexStatsByTableInfo->initLocalIndexInfos->generateLocalIndexInfosand generate useless logging like"Local index info does not changed, ..."for eachStorageDeltaMerge. This will cause much debug logging when there are lots of tables in the clusterWhat is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note