Skip to content

vector: Reduce logging under debug level (#9852)#9858

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-9852-to-release-8.5
Feb 10, 2025
Merged

vector: Reduce logging under debug level (#9852)#9858
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.5from
ti-chi-bot:cherry-pick-9852-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9852

What problem does this PR solve?

Issue Number: close #9854

Problem Summary:

When we try to add a vector index on a relative large table, there are much useless logging under debug level

  • After DDL owner try to add a vector index, the tidb ddl owner will get the add index progress by fetching system.dt_local_indexes from all tiflash instances
  • StorageSystemDTLocalIndexes::read call getLocalIndexesStatsFromStorage. For non-inited DeltaMergeStore, the function calls genLocalIndexStatsByTableInfo -> initLocalIndexInfos -> generateLocalIndexInfos and generate useless logging like "Local index info does not changed, ..." for each StorageDeltaMerge. This will cause much debug logging when there are lots of tables in the cluster

What is changed and how it works?

* Move the logging from `generateLocalIndexInfos` to `DeltaMergeStore::applyLocalIndexChange`. Reduce logging that is not cause by DDL changed
* Return the keep/added/dropped index ids in `LocalIndexInfosChangeset` and generate the changeset logging string by `LocalIndexInfosChangeset::toString`

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
Deploy a cluster with tiflash and enable debug level logging
Load a dataset with 1m vector data
Add vector index and wait
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Feb 8, 2025
@ti-chi-bot
Copy link
Member Author

@JaySon-Huang This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 10, 2025
@JaySon-Huang
Copy link
Contributor

/unhold
Conflict has been resolved

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2025
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-10 03:00:55.2832093 +0000 UTC m=+239097.679431362: ☑️ agreed by JaySon-Huang.
  • 2025-02-10 04:53:04.024085922 +0000 UTC m=+245826.420307979: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot merged commit 57da764 into pingcap:release-8.5 Feb 10, 2025
4 checks passed
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Mar 4, 2025
pingcap#362)

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
yongman pushed a commit to yongman/tiflash that referenced this pull request Jun 18, 2025
close pingcap#9854

* Move the logging from `generateLocalIndexInfos` to `DeltaMergeStore::applyLocalIndexChange`. Reduce logging that is not cause by DDL changed
* Return the keep/added/dropped index ids in `LocalIndexInfosChangeset` and generate the changeset logging string by `LocalIndexInfosChangeset::toString`

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants