Skip to content

Fix compilation errors with unused variables#9793

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
JinheLin:fix_unused
Jan 17, 2025
Merged

Fix compilation errors with unused variables#9793
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
JinheLin:fix_unused

Conversation

@JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jan 17, 2025 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9794, ref #7376

Problem Summary:

align_size is unused in release mode. introduced by #9737

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2025
xzhangxian1008
xzhangxian1008 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 17, 2025
@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-17 05:56:52.630315514 +0000 UTC m=+270884.085361663: ☑️ agreed by xzhangxian1008.
  • 2025-01-17 05:57:07.928128979 +0000 UTC m=+270899.383175128: ☑️ agreed by Lloyd-Pottiger.

CalvinNeo
CalvinNeo approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, gengliqi, Lloyd-Pottiger, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,Lloyd-Pottiger,gengliqi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 294d600 into pingcap:master Jan 17, 2025
@xzhangxian1008 xzhangxian1008 mentioned this pull request Jan 17, 2025
Merged
12 tasks
@JinheLin JinheLin deleted the fix_unused branch January 27, 2025 08:10
@xzhangxian1008
Copy link
Contributor

xzhangxian1008 commented Mar 11, 2025

/cherrypick release-8.5-20250310-v8.5.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2025

@xzhangxian1008: new pull request created to branch release-8.5-20250310-v8.5.1: #9992.

Details

In response to this:

/cherrypick release-8.5-20250310-v8.5.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 11, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Mar 11, 2025
@ti-chi-bot @JinheLin
Fix compilation errors with unused variables (#9793) (#9992)
a3035b6 
close #9794

Co-authored-by: jinhelin <linjinhe33@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@gengliqi gengliqi gengliqi approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

+1 more reviewer

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI build fail in release mode because of unused variable introduced in pr 9737

6 participants

@JinheLin @xzhangxian1008 @ti-chi-bot @CalvinNeo @gengliqi @Lloyd-Pottiger