Set proxy's memory limit by TiFlash (#9753) and update tiflash proxy#9776
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from Jan 9, 2025
Merged
Conversation
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Lloyd-Pottiger
approved these changes
Jan 9, 2025
close pingcap#9745 Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon <tshent@qq.com>
JaySon-Huang
approved these changes
Jan 9, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9745 ref #4982
Problem Summary:
What is changed and how it works?
After this, the memory_usage_limit on proxy's side will be:
If memory_usage_limit is set on proxy's side, use it
Otherwise:
If max_memory_usage_for_all_queries is not zero, use its size or ratio and compute on proxy's side.
Use default value MEMORY_USAGE_LIMIT_RATE
update proxy to raftstore-proxy-8.5
Proxy PR:
Including:\nSubmodule contrib/tiflash-proxy b877a97699..fdb7f17746:
Check List
Tests
Side effects
Documentation
Release note