[flash 855] support add primary key#409
Merged
hanfei1991 merged 17 commits intomasterfrom Feb 8, 2020
Merged
Conversation
Member
Author
|
/run-integration-tests |
Contributor
|
How is drop pk handled? |
Member
Author
|
@zanmato1984 drop pk will not change any column properties , so nothing need to do |
zanmato1984
reviewed
Feb 4, 2020
zanmato1984
reviewed
Feb 4, 2020
Member
Author
|
/rebuild |
Member
Author
|
/run-integration-tests |
1 similar comment
Member
Author
|
/run-integration-tests |
Contributor
|
Other than test scripts LGTM. I'll leave test scripts to @lidezhu to review. |
lidezhu
reviewed
Feb 5, 2020
| for output_line in outputs: | ||
| if not output_line.startswith('+'): | ||
| parsed_line = MySQLCompare.parse_mysql_line(output_line) | ||
| results.add(parsed_line) |
Contributor
There was a problem hiding this comment.
If the parsed_line is already in the set, this operation doesn't have any effect. You can follow the way in match function.
lidezhu
reviewed
Feb 5, 2020
| results = set() | ||
| for output_line in outputs: | ||
| parsed_line = MySQLCompare.parse_output_line(output_line) | ||
| results.add(parsed_line) |
Member
Author
|
/run-integration-tests |
2 similar comments
Member
Author
|
/run-integration-tests |
Member
Author
|
/run-integration-tests |
Member
Author
|
/rebuild |
Member
Author
|
/run-integration-tests |
Member
Author
|
/run-integrated-tests |
Member
Author
|
/run-integration-tests |
12 tasks
yongman
added a commit
to yongman/tiflash
that referenced
this pull request
Jun 18, 2025
…t_committed observer (pingcap#409) Signed-off-by: yongman <yming0221@gmail.com> Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Co-authored-by: Ray Yan <yming0221@gmail.com> Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add primary key is equal to alter multi columns in tiflash.