Skip to content

vector: Distinguish different vector index build type by metrics#9769

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
JaySon-Huang:align
Jan 7, 2025
Merged

vector: Distinguish different vector index build type by metrics#9769
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
JaySon-Huang:align

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jan 7, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9770

Problem Summary:

What is changed and how it works?

Add metrics to distinguish different vector index build type

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo @JaySon-Huang
Distinguish different vector index build type (pingcap#320)
0e4bbbe 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 7, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,breezewish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 08:25:36.343614957 +0000 UTC m=+255679.632446662: ☑️ agreed by Lloyd-Pottiger.
  • 2025-01-07 14:47:37.117636871 +0000 UTC m=+278600.406468580: ☑️ agreed by breezewish.

@breezewish
Copy link
Member

breezewish commented Jan 7, 2025

/merge

@ti-chi-bot ti-chi-bot bot merged commit c4cf3c0 into pingcap:master Jan 7, 2025
@JaySon-Huang JaySon-Huang deleted the align branch January 7, 2025 15:15
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jan 7, 2025
@CalvinNeo
Copy link
Member

CalvinNeo commented Jan 7, 2025

/cherry-pick release-8.5

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 7, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #9773.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 7, 2025

@CalvinNeo: new pull request could not be created: failed to create pull request against pingcap/tiflash#release-8.5 from head ti-chi-bot:cherry-pick-9769-to-release-8.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-9769-to-release-8.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 7, 2025
@ti-chi-bot @CalvinNeo
vector: Distinguish different vector index build type by metrics (#9769…
7275a8c 
…) (#9773)

close #9770

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Distinguish different vector index build type by metrics

5 participants

@JaySon-Huang @breezewish @CalvinNeo @ti-chi-bot @Lloyd-Pottiger