*: Make tiflash compatible with the cse branch#9765
*: Make tiflash compatible with the cse branch#9765ti-chi-bot[bot] merged 15 commits intopingcap:masterfrom
Conversation
2dbf453 to
236d14f
Compare
|
@yongman: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| Poco::Net::Context::VerificationMode::VERIFY_STRICT | ||
| #else | ||
| // mtls: metrics server allows anonymous pullers @iosmanthus | ||
| Poco::Net::Context::VerificationMode::VERIFY_RELAXED |
There was a problem hiding this comment.
Where does this line come from? Can not find on either tiflash master or cse
There was a problem hiding this comment.
it has been merge months ago https://github.com/tidbcloud/tiflash-cse/pull/216
| return false; | ||
| } | ||
| #else | ||
| if (version == cur_version) |
There was a problem hiding this comment.
// if the `version` is less than `cur_version`, it means that the schema version in TiKV has been rolled back by restore.
// We should sync the schema again.
Why won't this happen in TiFlash master?
There was a problem hiding this comment.
In TiFlash master, when executing flashback cluster, tidb won't overwrite the schema_version.
But in cse branch, they may restore the cluster by the data from S3. And this will lead to schema version rollbacked to a smaller version.
|
/cc @guo-shaoge Could you please also review the blocklist part? |
| Poco::Net::Context::VerificationMode::VERIFY_STRICT | ||
| #else | ||
| // mtls: metrics server allows anonymous pullers @iosmanthus | ||
| Poco::Net::Context::VerificationMode::VERIFY_RELAXED |
There was a problem hiding this comment.
it has been merge months ago https://github.com/tidbcloud/tiflash-cse/pull/216
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
3964824 to
5b38f50
Compare
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger, yongman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
close pingcap#9767 Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
What problem does this PR solve?
Issue Number: close #9767
Problem Summary:
What is changed and how it works?
The following adoption of cse only enable when
SERVERLESS_PROXY = 1is definedvarIntinstead ofu8Acquiring the all the region ids created in this TiFlash node with given keyspace idCheck List
Tests
Side effects
Documentation
Release note