Skip to content

PageCtl: Support getting blob data from PageStorage instance#9723

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
JaySon-Huang:enhance_page_ctl
Dec 12, 2024
Merged

PageCtl: Support getting blob data from PageStorage instance#9723
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
JaySon-Huang:enhance_page_ctl

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 11, 2024

What problem does this PR solve?

Issue Number: close #9716

Problem Summary:

What is changed and how it works?

PageCtl: Support getting blob data from PageStorage instance
And output the "PageEntryV3.offset" in decimal instead of hexadecimal

>  ./dbms/src/Server/tiflash pagectl -V 3 --mode 7 --blob_id 1060 --blob_offset 30413 --blob_size 47 -P /data1/1210_down/meta
Running with mode=DISPLAY_BLOB_DATA
...
checksum: 0xE1CB85684ED5E5B6
hex:030000000500000000000000220A18080010011A08800000000003D05C2208800000000007A11510F04418F744201A

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@JaySon-Huang
Support getting blob data from PageStorage instance
81135da 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Fix type
9a4ca2b 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Refine code
43340bb 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@JaySon-Huang
Remove useless code
a6f5510 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang JaySon-Huang removed needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Dec 11, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-11 11:03:10.674005334 +0000 UTC m=+436380.762807869: ☑️ agreed by JinheLin.
  • 2024-12-12 01:54:58.03030357 +0000 UTC m=+489888.119106114: ☑️ agreed by Lloyd-Pottiger.

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 12, 2024

/test pull-unit-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 12, 2024

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit c2c041c into pingcap:master Dec 12, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 12, 2024

In response to a cherrypick label: new pull request created to branch release-8.5: #9724.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 12, 2024
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#9723
8bae7a5 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 12, 2024
Merged
12 tasks
@JaySon-Huang JaySon-Huang deleted the enhance_page_ctl branch December 12, 2024 05:28
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 12, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2024
@ti-chi-bot @JaySon-Huang
PageCtl: Support getting blob data from PageStorage instance (#9723) (#…
8fdfebd 
…9724)

close #9716

PageCtl: Support getting blob data from PageStorage instance
And output the "PageEntryV3.offset" in decimal instead of hexadecimal

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
yongman pushed a commit to yongman/tiflash that referenced this pull request Jan 23, 2025
@JaySon-Huang @Lloyd-Pottiger @ti-chi-bot
PageCtl: Support getting blob data from PageStorage instance (pingcap…
b4eea55 
…#9723)

close pingcap#9716

PageCtl: Support getting blob data from PageStorage instance
And output the "PageEntryV3.offset" in decimal instead of hexadecimal

Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JinheLin JinheLin JinheLin approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance the debugging tool PageCtl

4 participants

@JaySon-Huang @ti-chi-bot @JinheLin @Lloyd-Pottiger