Skip to content

Disagg: Retry when the stream state of S3 is not good#9698

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JinheLin:read_s3_retry
Dec 4, 2024
Merged

Disagg: Retry when the stream state of S3 is not good#9698
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
JinheLin:read_s3_retry

Conversation

@JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Dec 4, 2024

What problem does this PR solve?

Issue Number: close #9695

Problem Summary:

The input stream of S3 may failed with errno is 0, but istr.rdstat() is abnormal.

What is changed and how it works?

Check the state of input stream and retry requests if state is abnormal.


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 4, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-04 10:20:25.851509476 +0000 UTC m=+1236613.471163988: ☑️ agreed by Lloyd-Pottiger.
  • 2024-12-04 10:54:11.960358303 +0000 UTC m=+1238639.580012819: ☑️ agreed by JaySon-Huang.

@JinheLin
Copy link
Contributor Author

JinheLin commented Dec 4, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit a98d04c into pingcap:master Dec 4, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Dec 4, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9700.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9701.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9702.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024
close #9695

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JaySon-Huang <tshent@qq.com>

Co-authored-by: jinhelin <linjinhe33@gmail.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 10, 2024
close #9695

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Co-authored-by: jinhelin <linjinhe33@gmail.com>
ti-chi-bot bot added a commit that referenced this pull request Dec 19, 2024
close #9695

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Co-authored-by: jinhelin <linjinhe33@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download data from S3 failed with: "cannot load checksum framed data from"

4 participants