Skip to content

Abort uploading checkpoint if s3 lock client is not initialized#9655

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
CalvinNeo:pick-lock
Nov 20, 2024
Merged

Abort uploading checkpoint if s3 lock client is not initialized#9655
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
CalvinNeo:pick-lock

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Nov 20, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9394

Problem Summary:

there is a time gap after TMTContext is created but before TMTContext::initS3GCManager finished

What is changed and how it works?

Do not init S3LocalLockManager, if the client is not set.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
Abort uploading checkpoint if s3 lock client is not initialized (ping…
51c7a32 
…cap#318)

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Nov 20, 2024
JaySon-Huang
JaySon-Huang approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 20, 2024
@JaySon-Huang JaySon-Huang changed the title Abort uploading checkpoint if s3 lock client is not initialized (#318) Abort uploading checkpoint if s3 lock client is not initialized Nov 20, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 20, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,breezewish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 20, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-20 03:08:55.892581193 +0000 UTC m=+1123.512235704: ☑️ agreed by JaySon-Huang.
  • 2024-11-20 03:09:46.219157479 +0000 UTC m=+1173.838811995: ☑️ agreed by breezewish.

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 20, 2024
@CalvinNeo
a
a641d5f 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@CalvinNeo
fix test 2
1447bed 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2024
@CalvinNeo
format
1e0bb8a 
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot merged commit 58bbc48 into pingcap:master Nov 20, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 20, 2024

In response to a cherrypick label: new pull request created to branch release-8.5: #9659.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2024
@ti-chi-bot @CalvinNeo
Abort uploading checkpoint if s3 lock client is not initialized (#9655)…
990562e 
… (#9659)

close #9394

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

Co-authored-by: Calvin Neo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UniPS: createS3Lock meets nullptr when FAP

4 participants

@CalvinNeo @ti-chi-bot @breezewish @JaySon-Huang