Skip to content

Storages: some minor refine#9649

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
Lloyd-Pottiger:refine-DeltaMerge
Nov 19, 2024
Merged

Storages: some minor refine#9649
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
Lloyd-Pottiger:refine-DeltaMerge

Conversation

@Lloyd-Pottiger
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2024
Lloyd-Pottiger and others added 3 commits November 18, 2024 17:47
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 19, 2024
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 02:31:23.199576566 +0000 UTC m=+928245.390445563: ☑️ agreed by JaySon-Huang.
  • 2024-11-19 02:37:27.753726087 +0000 UTC m=+928609.944595083: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot merged commit d064f96 into pingcap:master Nov 19, 2024
@Lloyd-Pottiger Lloyd-Pottiger deleted the refine-DeltaMerge branch November 19, 2024 03:13
@Lloyd-Pottiger Lloyd-Pottiger mentioned this pull request Nov 19, 2024
12 tasks
yongman pushed a commit to yongman/tiflash that referenced this pull request Jun 18, 2025
pingcap#9649

Signed-off-by: Wish <breezewish@outlook.com>
yongman pushed a commit to yongman/tiflash that referenced this pull request Jun 18, 2025
pingcap#9649

Signed-off-by: Wish <breezewish@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants