Skip to content

Fix the bug that cloneFullColumn does not clone the subcolumns at the second and higher levels #9606

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
gengliqi:fix-clone-column
Nov 13, 2024
Merged

Fix the bug that cloneFullColumn does not clone the subcolumns at the second and higher levels #9606
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
gengliqi:fix-clone-column

Conversation

@gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Nov 12, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9605

Problem Summary:
See #9605
The newly-added unit test will fail for the original codebase.

What is changed and how it works?

Fix the bug that `cloneFullColumn` does not clone the subcolumns at the second and higher levels

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@gengliqi
u
f40e9ed 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Nov 12, 2024
@gengliqi gengliqi requested a review from windtalker November 12, 2024 15:15
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 12, 2024
@gengliqi
format
a99b057 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
windtalker
windtalker approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 13, 2024
yibin87
yibin87 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 13, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-13 01:23:01.946805993 +0000 UTC m=+405744.137674983: ☑️ agreed by windtalker.
  • 2024-11-13 01:54:27.147514006 +0000 UTC m=+407629.338383000: ☑️ agreed by yibin87.

@ti-chi-bot ti-chi-bot bot merged commit e591694 into pingcap:master Nov 13, 2024
@gengliqi gengliqi added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 13, 2024
@gengliqi gengliqi deleted the fix-clone-column branch November 13, 2024 02:07
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 13, 2024

In response to a cherrypick label: new pull request created to branch release-8.5: #9607.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 13, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 13, 2024
@ti-chi-bot @gengliqi
Fix the bug that cloneFullColumn does not clone the subcolumns at t…
d346b92 
…he second and higher levels (#9606) (#9607)

close #9605

Fix the bug that `cloneFullColumn` does not clone the subcolumns at the second and higher levels

Signed-off-by: gengliqi <gengliqiii@gmail.com>

Co-authored-by: gengliqi <gengliqiii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cloneFullColumn does not clone the subcolumns at the second and higher levels

4 participants

@gengliqi @ti-chi-bot @windtalker @yibin87