Skip to content

Fix the fail start of tiflash because of the zero division when getting cpu number#9602

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
xzhangxian1008:fix-9212
Nov 15, 2024
Merged

Fix the fail start of tiflash because of the zero division when getting cpu number#9602
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
xzhangxian1008:fix-9212

Conversation

@xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Nov 12, 2024

What problem does this PR solve?

Issue Number: close #9212

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the that fail to start tiflash because of the zero division when getting cpu number

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2024
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Nov 12, 2024

/cc @yibin87 @Lloyd-Pottiger

Lloyd-Pottiger
Lloyd-Pottiger reviewed Nov 12, 2024
View reviewed changes
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 12, 2024
yibin87
yibin87 reviewed Nov 14, 2024
View reviewed changes
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Nov 14, 2024

/cc @yibin87

yibin87
yibin87 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lloyd-Pottiger, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,yibin87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 15, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-12 08:46:15.735503205 +0000 UTC m=+345937.926372195: ☑️ agreed by Lloyd-Pottiger.
  • 2024-11-15 03:06:28.20481276 +0000 UTC m=+584750.395681756: ☑️ agreed by yibin87.

@Lloyd-Pottiger
Copy link
Contributor

Lloyd-Pottiger commented Nov 15, 2024

/retest

@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Nov 15, 2024

/run-unit-test

@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Nov 15, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1af89a5 into pingcap:master Nov 15, 2024
@xzhangxian1008 xzhangxian1008 deleted the fix-9212 branch November 15, 2024 09:36
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Nov 15, 2024

/cherrypick release-8.5

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2024

@xzhangxian1008: new pull request created to branch release-8.5: #9623.

Details

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Merged
12 tasks
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Nov 15, 2024

/cherrypick release-8.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2024

@xzhangxian1008: new pull request created to branch release-8.1: #9624.

Details

In response to this:

/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Merged
12 tasks
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Nov 15, 2024

/cherrypick release-7.5

@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Nov 15, 2024

/cherrypick release-7.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2024

@xzhangxian1008: new pull request created to branch release-7.5: #9625.

Details

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Merged
12 tasks
@xzhangxian1008
Copy link
Contributor Author

xzhangxian1008 commented Nov 15, 2024

/cherrypick release-6.5

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Nov 15, 2024
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#9602
b3064fd 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2024

@xzhangxian1008: new pull request created to branch release-7.1: #9626.

Details

In response to this:

/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Nov 15, 2024
@xzhangxian1008 @ti-chi-bot
This is an automated cherry-pick of pingcap#9602
6c1a5a1 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2024

@xzhangxian1008: new pull request created to branch release-6.5: #9627.

Details

In response to this:

/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 15, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 15, 2024
@ti-chi-bot @xzhangxian1008
Fix the fail start of tiflash because of the zero division when getti…
7e698b2 
…ng cpu number (#9602) (#9623)

close #9212

Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot @xzhangxian1008 @JaySon-Huang
Fix the fail start of tiflash because of the zero division when getti…
f36d293 
…ng cpu number (#9602) (#9625)

close #9212

Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>
Co-authored-by: JaySon <tshent@qq.com>
ti-chi-bot bot added a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot @xzhangxian1008
@JaySon-Huang @ti-chi-bot
Fix the fail start of tiflash because of the zero division when getti…
594fda8 
…ng cpu number (#9602) (#9624)

close #9212

Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>
Co-authored-by: JaySon <tshent@qq.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot @xzhangxian1008
Fix the fail start of tiflash because of the zero division when getti…
c55bfae 
…ng cpu number (#9602) (#9626)

close #9212

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot @xzhangxian1008
@purelind @JaySon-Huang
Fix the fail start of tiflash because of the zero division when getti…
f12b255 
…ng cpu number (#9602) (#9627)

close #9212

Co-authored-by: xzhangxian1008 <xzhangxian@foxmail.com>
Co-authored-by: Purelind <purelind@users.noreply.github.com>
Co-authored-by: JaySon <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to start TiFlash when some CPUs are offline

4 participants

@xzhangxian1008 @Lloyd-Pottiger @ti-chi-bot @yibin87