Skip to content

refine resource group task_count metric#9594

Merged
ti-chi-bot[bot] merged 10 commits intopingcap:masterfrom
guo-shaoge:refine_rg_task_cnt_metric
Nov 8, 2024
Merged

refine resource group task_count metric#9594
ti-chi-bot[bot] merged 10 commits intopingcap:masterfrom
guo-shaoge:refine_rg_task_cnt_metric

Conversation

@guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Nov 7, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9595

Problem Summary: make task count metric to type Counter to avoid we cannot observe very fast MPP Task execution.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@guo-shaoge
refine resource group task_count metric
2c69af6 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2024
@guo-shaoge
fix
1712d42 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix
4524923 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Merge branch 'refine_rg_task_cnt_metric' of github.com:guo-shaoge/tif…
d2c7870 
…lash into refine_rg_task_cnt_metric
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2024
@guo-shaoge
fix
0bb18be 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fmt
671e394 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
fix
fbce6f6 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge guo-shaoge requested a review from gengliqi November 8, 2024 09:47
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 8, 2024
yibin87
yibin87 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 8, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 8, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-08 09:58:30.560983853 +0000 UTC m=+4672.751852845: ☑️ agreed by gengliqi.
  • 2024-11-08 09:59:06.838065289 +0000 UTC m=+4709.028934280: ☑️ agreed by yibin87.

@ti-chi-bot ti-chi-bot bot merged commit 750c4de into pingcap:master Nov 8, 2024
@JaySon-Huang JaySon-Huang deleted the refine_rg_task_cnt_metric branch January 6, 2025 15:31
@guo-shaoge
Copy link
Contributor Author

guo-shaoge commented Jan 7, 2025

/cherry-pick release-8.5

@guo-shaoge guo-shaoge added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jan 7, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 7, 2025

@guo-shaoge: new pull request created to branch release-8.5: #9768.

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 7, 2025
Merged
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 7, 2025

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tiflash#release-8.5 from head ti-chi-bot:cherry-pick-9594-to-release-8.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-9594-to-release-8.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

ti-chi-bot bot pushed a commit that referenced this pull request Jan 7, 2025
@ti-chi-bot @guo-shaoge
refine resource group task_count metric (#9594) (#9768)
34e5c14 
close #9595

Signed-off-by: guo-shaoge <shaoge1994@163.com>

Co-authored-by: guo-shaoge <shaoge1994@163.com>
yongman pushed a commit to yongman/tiflash that referenced this pull request Jun 18, 2025
@ti-chi-bot @guo-shaoge @JaySon-Huang
refine resource group task_count metric (pingcap#9594) (pingcap#9768)
4c39636 
close pingcap#9595

Signed-off-by: guo-shaoge <shaoge1994@163.com>

Co-authored-by: guo-shaoge <shaoge1994@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 approved these changes

@gengliqi gengliqi gengliqi approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

change the type of task count metric as Counter

4 participants

@guo-shaoge @ti-chi-bot @yibin87 @gengliqi