Skip to content

Add pipeline wait time of minTSO and pipeline breaker in execution summary#9566

Merged
ti-chi-bot[bot] merged 33 commits intopingcap:masterfrom
yibin87:add_pipeline_wait_time
Nov 13, 2024
Merged

Add pipeline wait time of minTSO and pipeline breaker in execution summary#9566
ti-chi-bot[bot] merged 33 commits intopingcap:masterfrom
yibin87:add_pipeline_wait_time

Conversation

@yibin87
Copy link
Contributor

@yibin87 yibin87 commented Oct 30, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9489

Problem Summary:

What is changed and how it works?

This PR mainly does three things:

  1. Add minTSO schedule time in execution summary for source ops.
  2. Add pipeline breaker wait time info in execution summary.
  3. Add the queue waiting time only on source ops instead of distribute the time averagely among all operators.

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Oct 30, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Oct 30, 2024

/run-all-tests

1 similar comment
@yibin87
Copy link
Contributor Author

yibin87 commented Oct 30, 2024

/run-all-tests

@yibin87 yibin87 force-pushed the add_pipeline_wait_time branch from 754e013 to 98ff6bf Compare October 30, 2024 09:55
@yibin87 yibin87 changed the title [DNM] Add pipeline wait time of minTSO and pipeline breaker in execution summary Add pipeline wait time of minTSO and pipeline breaker in execution summary Oct 31, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Oct 31, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2024
@yibin87 yibin87 force-pushed the add_pipeline_wait_time branch from 6918b9d to 002bc93 Compare October 31, 2024 05:07
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2024
@yibin87 yibin87 force-pushed the add_pipeline_wait_time branch from 002bc93 to 8152c1e Compare October 31, 2024 05:10
@yibin87 yibin87 requested a review from windtalker November 1, 2024 02:15
@yibin87
Copy link
Contributor Author

yibin87 commented Nov 1, 2024

/cc @SeaRise

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 1, 2024

@yibin87: GitHub didn't allow me to request PR reviews from the following users: SeaRise.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @SeaRise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87 yibin87 requested a review from gengliqi November 1, 2024 02:18
@yibin87
Copy link
Contributor Author

yibin87 commented Nov 1, 2024

/run-all-tests

SeaRise
SeaRise reviewed Nov 4, 2024
View reviewed changes
@yibin87 yibin87 requested a review from SeaRise November 5, 2024 08:53
@yibin87
Copy link
Contributor Author

yibin87 commented Nov 6, 2024

/test pull-integration-test

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2024
@yibin87 yibin87 force-pushed the add_pipeline_wait_time branch from 7f686cd to 422ad2c Compare November 6, 2024 05:09
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 6, 2024
@yibin87 yibin87 force-pushed the add_pipeline_wait_time branch from 422ad2c to 714c054 Compare November 6, 2024 05:11
yibin87 and others added 4 commits November 11, 2024 11:00
@yibin87
Fix compilation issue
857600c 
Signed-off-by: yibin <huyibin@pingcap.com>
Remove useless pipeline breaker wait time in operator profile info
9500087 
Signed-off-by: yibin <huyibin@pingcap.cn>
@yibin87
Fix format issue
95684ef 
Signed-off-by: yibin <huyibin@pingcap.com>
Address comment to add todo comment
a531b62 
Signed-off-by: yibin <huyibin@pingcap.cn>
@yibin87 yibin87 force-pushed the add_pipeline_wait_time branch from f6bed58 to a531b62 Compare November 11, 2024 03:01
SeaRise
SeaRise approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 11, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Nov 11, 2024

/test pull-integration-test

@yibin87
Copy link
Contributor Author

yibin87 commented Nov 11, 2024

/test pull-unit-test

1 similar comment
@yibin87
Copy link
Contributor Author

yibin87 commented Nov 11, 2024

/test pull-unit-test

yibin added 2 commits November 11, 2024 17:32
Little update
7396209 
Signed-off-by: yibin <huyibin@pingcap.cn>
Adjust schedule duration in Events
a40ddc6 
Signed-off-by: yibin <huyibin@pingcap.cn>
windtalker
windtalker approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 13, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 13, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 03:26:21.353960008 +0000 UTC m=+240343.544829001: ☑️ agreed by SeaRise.
  • 2024-11-13 03:18:10.494836202 +0000 UTC m=+412652.685705199: ☑️ agreed by windtalker.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 13, 2024

@yibin87: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Nov 13, 2024

/test pull-integration-test

@yibin87
Copy link
Contributor Author

yibin87 commented Nov 13, 2024

/test pull-unit-test

@yibin87
Copy link
Contributor Author

yibin87 commented Nov 13, 2024

/test pull-integration-test

@yibin87
Copy link
Contributor Author

yibin87 commented Nov 13, 2024

/test pull-unit-test

1 similar comment
@yibin87
Copy link
Contributor Author

yibin87 commented Nov 13, 2024

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 15ed3cf into pingcap:master Nov 13, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 14, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 14, 2024

In response to a cherrypick label: new pull request created to branch release-8.5: #9612.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 14, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 14, 2024
@ti-chi-bot @yibin87
Add pipeline wait time of minTSO and pipeline breaker in execution su…
303c273 
…mmary (#9566) (#9612)

close #9489

Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.cn>

Co-authored-by: yibin <huyibin@pingcap.com>
Co-authored-by: yibin <huyibin@pingcap.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@gengliqi gengliqi Awaiting requested review from gengliqi

+1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The execution time in pipeline mode is distortion sometimes

4 participants

@yibin87 @ti-chi-bot @windtalker @SeaRise