vector: Fix ColumnArray does not work well with CHBlockChunkCodec#9477
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
[LGTM Timeline notifier]Timeline:
|
|
@JaySon-Huang: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ngcap#9477) close pingcap#9485 vector: Fix ColumnArray does not work well with CHBlockChunkCodec Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: close #9485
Problem Summary:
When MPP tasks exchange data with type
Array(Float32),CHBlockChunkDecodeAndSquashwill try to merged the deserialized data into a larger block. ButCHBlockChunkCodecandCHBlockChunkDecodeAndSquashseri/deseri the array data withposition_independent_encoding == false, which cause thecolumn_array.offsetsstore incorrect data and causes invalid memory access.What is changed and how it works?
position_independent_encoding == trueinCHBlockChunkCodecandCHBlockChunkDecodeAndSquash. So that the array data can be correctly serialized and deserializedDataTypeArray::deserializeBinaryBulkWithMultipleStreams. If the function is called withposition_independent_encoding == false, and try to deserialize data into a non-empty column, throw an exceptionCheck List
Tests
Side effects
Documentation
Release note