ddl: fix TypeBit default value#9467
Merged
ti-chi-bot[bot] merged 12 commits intopingcap:masterfrom Sep 26, 2024
Merged
Conversation
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Member
|
Why we need to update Poco here? |
Contributor
Author
Check pingcap/poco#22 |
Comment on lines
-159
to
-166
| // TODO: We shall use something like `orig_default_bit`, which will never change once created, | ||
| // rather than `default_bit`, which could be altered. | ||
| // See https://github.com/pingcap/tidb/issues/17641 and https://github.com/pingcap/tidb/issues/17642 | ||
| const auto & bit_value = default_bit_value; | ||
| // TODO: There might be cases that `orig_default` is not null but `default_bit` is null, | ||
| // i.e. bit column added with an default value but later modified to another. | ||
| // For these cases, neither `orig_default` (may get corrupted) nor `default_bit` (modified) is correct. | ||
| // This is a bug anyway, we choose to make it simple, i.e. use `default_bit`. |
Contributor
There was a problem hiding this comment.
origin_default_bit_value is added since which version?
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Contributor
Author
JaySon-Huang
approved these changes
Sep 26, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 27, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Sep 27, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
Contributor
Author
|
/cherry-pick release-7.1 |
Contributor
Author
|
/cherry-pick release-6.5 |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
@Lloyd-Pottiger: failed to apply #9467 on top of branch "release-6.5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This comment was marked as resolved.
This comment was marked as resolved.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9461
Problem Summary:
What is changed and how it works?
Fix two problems:
origin_default_bit_value.Check List
Tests
Side effects
Documentation
Release note