Skip to content

Disagg: Set the waiting time for thread pool.#9393

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
JinheLin:fix_uni_threads
Sep 2, 2024
Merged

Disagg: Set the waiting time for thread pool.#9393
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
JinheLin:fix_uni_threads

Conversation

@JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Sep 2, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9392 ref #9334

Problem Summary:

The default wait_microseconds is 0, which means never wait.

What is changed and how it works?

Set wait_microseconds to disagg_build_task_timeout.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 2, 2024
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 2, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 2, 2024
CalvinNeo
CalvinNeo approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 2, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-02 07:56:36.744812955 +0000 UTC m=+258321.262865882: ☑️ agreed by Lloyd-Pottiger.
  • 2024-09-02 08:42:23.970704195 +0000 UTC m=+261068.488757120: ☑️ agreed by CalvinNeo.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2024

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 738aade into pingcap:master Sep 2, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Sep 2, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Sep 2, 2024
@JinheLin @ti-chi-bot
This is an automated cherry-pick of pingcap#9393
d75368e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2024
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 2, 2024

In response to a cherrypick label: new pull request created to branch release-8.1: #9395.

JinheLin added a commit that referenced this pull request Sep 3, 2024
@JinheLin @ti-chi-bot
Disagg: Set the waiting time for thread pool. (#9393)
328e207 
close #9392

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JinheLin JinheLin mentioned this pull request Sep 3, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Sep 4, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 29, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2024

In response to a cherrypick label: new pull request created to branch release-7.5: #9686.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Nov 29, 2024
@JinheLin @ti-chi-bot
This is an automated cherry-pick of pingcap#9393
70c7aed 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 29, 2024
Closed
12 tasks
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DB::Exception: Cannot schedule a task: no free thread (timeout=0) (threads=60, jobs=120)

4 participants

@JinheLin @ti-chi-bot @CalvinNeo @Lloyd-Pottiger