KVStore: Fix spurious region overlap when two region are both applying snapshots#9330
Merged
ti-chi-bot[bot] merged 19 commits intopingcap:masterfrom Aug 20, 2024
Merged
Conversation
Comment on lines
+225
to
+227
| dm_storage->deleteRange(new_key_range, context.getSettingsRef()); | ||
| // We must flush the deletion to the disk here, because we only flush new range when persisting this region later. | ||
| dm_storage->flushCache(context, old_key_range, /*try_until_succeed*/ true); | ||
| dm_storage->flushCache(context, new_key_range, /*try_until_succeed*/ true); |
Contributor
There was a problem hiding this comment.
Why here is changed to delete the new_key_range?
Member
Author
There was a problem hiding this comment.
Consider:
- apply snapshot a of range [0..100)
- apply snapshot b of range [50..100)
- apply snapshot a' of range [0..50)
In 3, we could clean the old range [0..100), which covers the written data of snapshot b in stage 2
Contributor
There was a problem hiding this comment.
If we only need to delete the existing data on the new_range, then the following code of ingestFiles(..., /*clear_data_in_range=*/true, ...) can do it. We don't need this branch.
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Contributor
|
Are these failed tests related to your changes? |
Co-authored-by: JaySon <tshent@qq.com>
… fix-simu-snapshot
Co-authored-by: Lloyd-Pottiger <60744015+Lloyd-Pottiger@users.noreply.github.com>
Co-authored-by: JaySon <tshent@qq.com>
Member
Author
|
/hold |
… fix-simu-snapshot
Member
Author
|
/unhold |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
CalvinNeo
added a commit
to CalvinNeo/tiflash
that referenced
this pull request
Nov 7, 2024
…g snapshots (pingcap#9330) close pingcap#9329 Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Co-authored-by: JaySon <tshent@qq.com> Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
12 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Nov 8, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
Closed
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9329
Problem Summary:
See the issue.
What is changed and how it works?
new_regionrather thanold_region.Check List
Tests
Side effects
Documentation
Release note