UniPS: Provide more information when meets exception in updateLocalCacheForRemotePage#9311
UniPS: Provide more information when meets exception in updateLocalCacheForRemotePage#9311ti-chi-bot[bot] merged 13 commits intopingcap:masterfrom
Conversation
|
/hold |
| if unlikely (last_iter == entries.end() || !last_iter->second.isEntry()) | ||
| { | ||
| FmtBuffer buf; | ||
| for (const auto & e : entries) |
There was a problem hiding this comment.
Also have a question: what's the size of entries normally?
There was a problem hiding this comment.
In my case, the size is 2
You hold this because you want to add some more logs, or because you want to attach the fix for jemalloc cmake? @JaySon-Huang |
Co-authored-by: JaySon <tshent@qq.com>
|
@CalvinNeo |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
BTW, the best way to locate data corruption of PageStorage restore, is keep the "wal" of PageStorage and replay it locally to check the entries written in the "wal". The message dump from the in-memory |
|
@CalvinNeo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…cheForRemotePage (pingcap#9311) (pingcap#265) Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Co-authored-by: JaySon-Huang <tshent@qq.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: ref #9307
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note