Skip to content

Accumulated updates for heap profiling#9240

Merged
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
CalvinNeo:add-more-mem-prof
Jul 19, 2024
Merged

Accumulated updates for heap profiling#9240
ti-chi-bot[bot] merged 5 commits intopingcap:masterfrom
CalvinNeo:add-more-mem-prof

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jul 19, 2024 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9241 close #3236

Problem Summary:

What is changed and how it works?

Enable ENABLE_JEMALLOC_PROF by default

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

CalvinNeo added 2 commits July 19, 2024 10:51
@CalvinNeo
pick
7e9c9f3 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
a
195e21b 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2024
@CalvinNeo
a
3dcbac1 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Jul 19, 2024
Lloyd-Pottiger
Lloyd-Pottiger reviewed Jul 19, 2024
View reviewed changes
@CalvinNeo CalvinNeo requested a review from Lloyd-Pottiger July 19, 2024 05:35
@CalvinNeo
a
bcd734f 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 19, 2024
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 19, 2024

mv: can't rename 'log': No such file or directory

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 19, 2024

/retest

1 similar comment
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 19, 2024

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,breezewish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-19 05:53:44.377029912 +0000 UTC m=+592446.367971382: ☑️ agreed by Lloyd-Pottiger.
  • 2024-07-19 07:23:33.493537721 +0000 UTC m=+597835.484479186: ☑️ agreed by breezewish.

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 19, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9073df5 into pingcap:master Jul 19, 2024
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@CalvinNeo
Accumulated updates for heap profiling (pingcap#9240) (pingcap#247)
2724412 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@JaySon-Huang JaySon-Huang mentioned this pull request Nov 26, 2024
Open
8 tasks
@JaySon-Huang JaySon-Huang mentioned this pull request May 12, 2025
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

KVStore & Proxy infra issue tracker TiFlash get stuck occasionally when mem-profiling is actived

3 participants

@CalvinNeo @breezewish @Lloyd-Pottiger