Skip to content

KVStore: More metrics for Prehandling#9131

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
CalvinNeo:more-snapshot-metric
Jun 7, 2024
Merged

KVStore: More metrics for Prehandling#9131
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
CalvinNeo:more-snapshot-metric

Conversation

@CalvinNeo
Copy link
Member

What problem does this PR solve?

Issue Number: close #8081

Problem Summary:

What is changed and how it works?


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

a
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 7, 2024
a
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 7, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-07 07:30:01.451141704 +0000 UTC m=+104155.504453613: ☑️ agreed by Lloyd-Pottiger.
  • 2024-06-07 07:51:36.33143753 +0000 UTC m=+105450.384749454: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit cbac09d into pingcap:master Jun 7, 2024
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parallel prehandle snapshot to speed up catch up with TiKV large region

3 participants