Storage: Fix max-id being mis-reused cause data corruption after changing tiflash replica number (#8698)#8733
Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-7.5from Jan 26, 2024
Conversation
12 tasks
a769a08 to
0663cd4
Compare
12 tasks
Contributor
|
/run-all-tests |
Lloyd-Pottiger
approved these changes
Jan 25, 2024
Contributor
Lloyd-Pottiger
left a comment
There was a problem hiding this comment.
remove all #include <Storages/DeltaMerge/Segment_fwd.h>
JinheLin
approved these changes
Jan 25, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
|
/run-all-tests |
2 similar comments
Contributor
|
/run-all-tests |
Contributor
|
/run-all-tests |
ff8e829 to
e6fccfe
Compare
Contributor
|
/run-all-tests |
Contributor
|
/run-integration-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an manual cherry-pick of #8701 and #8698
What problem does this PR solve?
Issue Number: close #8695
Problem Summary: As the issue describe: #8695 (comment)
What is changed and how it works?
Introduce a
GlobalPageIdAllocatorto avoid a page_id from being reused in one physical_table_id scope. Specifically,GlobalPageIdAllocatorto allocate page_id for segment_id, delta-layer and stable-layer for all IStorage instances instead of eachStoragePoolallocate the page_id for its own IStorage instance independentlyGlobalPageIdAllocator. After that, a table won't be able to reuse the allocated idGlobalPageIdAllocator, so no page_id will be reused too.Check List
Tests
Side effects
Documentation
Release note